Open
Conversation
…into tensor-scale-nvfp4
awni
reviewed
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add per tensor scale for
nvfp4quantization forcudaandcpu.qqmm,quantize,dequantizeinputs optional 1Dfloat32array (global_scale) ifmode == "nvfp4".Also some files related to
qqmmwere refactored.Important details:
qqmm] currently ifglobal_scaleis provided for the first input, it must be provided for the second input as well. This is because we pass global scales as inputs inQQMatmul::eval_gpu()and we can't distinguish betweenglobal_scale_xandglobal_scale_w.alphaandbetaboth should be device or host ptrs. Therefore, ifalphais a device ptr,Tensor scale will help with small inputs:
TODO:
global_scalein metal as well but it requires changing all quantized operationsx,was well as forcotan), thereforeQQLineardoes not have global scale support. I will add it after some exploration as a separate PR.fp_qmv_implwas not updated yet to support global scale